Modify generate API #169
Merged
Modify generate API #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haiyan Meng <hmeng@redhat.com>
|
@mrunalp , PTAL. |
|
@mrunalp , to make it easy for you to test the PR, here is the test command for testing all the changed functions in this PR: |
|
LGTM |
| @@ -461,14 +456,9 @@ func (g *Generator) ClearLinuxSysctl() { | |||
| } | |||
|
|
|||
| // AddLinuxSysctl adds a new sysctl config into g.spec.Linux.Sysctl. | |||
| func (g *Generator) AddLinuxSysctl(s string) error { | |||
| func (g *Generator) AddLinuxSysctl(key, value string) error { | |||
There was a problem hiding this comment.
It seems this function does not need return error any more. Same as other AddXXXX() function.
There was a problem hiding this comment.
@Mashimiao , thanks for pointing out. Fixed it. PTAL.
I also change the param of AddProcessAdditionalGid from string to uint32.
added 2 commits
July 29, 2016 11:30
Signed-off-by: Haiyan Meng <hmeng@redhat.com>
Signed-off-by: Haiyan Meng <hmeng@redhat.com>
|
@mrunalp , PTAL. |
|
LGTM |
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Aug 3, 2016
Signed-off-by: Haiyan Meng <hmeng@redhat.com> Backported to v1.0.0.rc1 from a217d8c opencontainers#169 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Aug 3, 2016
Signed-off-by: Haiyan Meng <hmeng@redhat.com> Backported to v1.0.0.rc1 from b31cc61 opencontainers#169 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Aug 3, 2016
Signed-off-by: Haiyan Meng <hmeng@redhat.com> Backported to v1.0.0.rc1 from a99f698 opencontainers#169 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the generate API easier to use. For example, instead of feeding a whole string to
AddAnnotation, the new API allows the user to feed a key and a value toAddAnnotation.Note: This PR does not touch any seccomp-relative function to avoid conflicts with Grant's work.
Signed-off-by: Haiyan Meng hmeng@redhat.com