config: clarify source mount #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The 'source' of a bind mount can either be a file or a directory. - The 'type' field is a dummy in case of bind mounts, often left to "none" (in that case it does not have to be something listed in /proc/filesystems). - 'Relative' paths can only be used for bind mounts, not for other mounts. That's how runc manages this. Replaces: opencontainers#967 Signed-off-by: Alban Crequy <alban@kinvolk.io>
|
LGTM |
|
@cyphar I seem to recall you had opinions around this, do I remember correctly? 😅 |
|
LGTM |
This was referenced Sep 13, 2018
wking
reviewed
Sep 13, 2018
| @@ -100,7 +101,7 @@ On all other platforms, this field is REQUIRED. | |||
| For POSIX platforms the `mounts` structure has the following fields: | |||
|
|
|||
| * **`type`** (string, OPTIONAL) The type of the filesystem to be mounted. | |||
| * Linux: filesystem types supported by the kernel as listed in */proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs", "reiserfs", "msdos", "proc", "nfs", "iso9660"). | |||
| * Linux: filesystem types supported by the kernel as listed in */proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs", "reiserfs", "msdos", "proc", "nfs", "iso9660"). For bind mounts (when `options` include either `bind` or `rbind`), the type is a dummy, often "none" (not listed in */proc/filesystems*). | |||
There was a problem hiding this comment.
Do we need to recomment none? Why not just leave this OPTIONAL property unset in that case?
|
I feel "none" accomplishes that and is the current de facto on linux
…On Thu, 2018-09-13 at 07:53 -0700, W. Trevor King wrote:
@wking commented on this pull request.
In config.md:
> @@ -100,7 +101,7 @@ On all other platforms, this field is REQUIRED.
For POSIX platforms the `mounts` structure has the following fields:
* **`type`** (string, OPTIONAL) The type of the filesystem to be
mounted.
- * Linux: filesystem types supported by the kernel as listed in
*/proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs",
"reiserfs", "msdos", "proc", "nfs", "iso9660").
+ * Linux: filesystem types supported by the kernel as listed in
*/proc/filesystems* (e.g., "minix", "ext2", "ext3", "jfs", "xfs",
"reiserfs", "msdos", "proc", "nfs", "iso9660"). For bind mounts (when
`options` include either `bind` or `rbind`), the type is a dummy,
often "none" (not listed in */proc/filesystems*).
Do we need to recomment none? Why not just leave this OPTIONAL
property unset in that case?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'source' of a bind mount can either be a file or a directory.
The 'type' field is a dummy in case of bind mounts, often left to
"none" (in that case it does not have to be something listed in
/proc/filesystems).
'Relative' paths can only be used for bind mounts, not for other
mounts. That's how runc manages this.
Replaces: #967
Signed-off-by: Alban Crequy alban@kinvolk.io