Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime.md #9

Closed

Conversation

hannibalhuang
Copy link

Add a section on Modification

@philips
Copy link
Contributor

philips commented Jun 25, 2015

@hannibalhuang Was this an accidental PR? What are you trying to express with modify?

@hannibalhuang
Copy link
Author

@philips For life cycle management usually we got create,modify and terminate, my thinking was simply adding a modification section currently is missing. But if there is more to come then I'm willing to close it :)

@philips
Copy link
Contributor

philips commented Jun 25, 2015

@hannibalhuang what sorts of things do you want to modify? In the create side it is mostly setting up namespace before exec'ing the target app. On the terminate side it is cleaning up said namespaces.

@hannibalhuang
Copy link
Author

@philips so what I have in mind are stuff like change container size due to Mesos policy, storage back-end change, network port change and so forth.

@philips
Copy link
Contributor

philips commented Jun 25, 2015

@hannibalhuang I think it is a bit early for any of these concepts. At some point we might turn the discussion towards things like updating cgroups isolation, etc.

@hannibalhuang
Copy link
Author

@philips sounds reasonable to me :) BTW updating isolation is still one kind of modification operation right?

@jonboulle
Copy link
Contributor

@hannibalhuang see #17

@philips
Copy link
Contributor

philips commented Jun 25, 2015

I am going to close this in favor of #17.

@philips philips closed this Jun 25, 2015
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Jul 6, 2016
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY,
...), 2015-12-02, opencontainers#9).

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants