*: Use inline links for remaining internal references #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since f9dc90b (make link usage consistent across the specification, 2017-02-09, opencontainers#687), the official style is to only use reference-style links for external links. I expect the remaining three entries just slipped through. This commit adjusts everything found with: $ git grep ']: [a-z]' | grep -v http It also fixes the underscore -> hyphen in the glossary.md#container-namespace target and updates the capabilities location to catch up with 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <wking@tremily.us>
tianon
reviewed
May 10, 2017
| The config JSON isn't enough of a UI to be worth jumping through string <-> integer hoops to support an 0x… form ([source][integer-over-hex]). | ||
|
|
||
| ## <a name="styleConstantNames" />Constant names should keep redundant prefixes | ||
|
|
||
| For example, `CAP_KILL` instead of `KILL` in [**`linux.capabilities`**][capabilities]. | ||
| For example, `CAP_KILL` instead of `KILL` in [**`process.capabilities`**](config.md#process). |
There was a problem hiding this comment.
Shouldn't this be config.md#configProcess?
(## <a name="configProcess" />Process is the section header of config.md which mentions capabilities)
There was a problem hiding this comment.
Shouldn't this be
config.md#configProcess?
That would work too. I'm currently using the auto-generated fragments to match @mrunalp's preference. I don't care either way, although I'd prefer the spec consistently use whichever way maintainers want.
|
LGTM Thanks for clarifying @wking. 👍 |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #687, the official style is to only use reference-style links for external links. I expect the remaining three entries just slipped through. This commit adjusts everything found with:
It also fixes the underscore → hyphen in the
glossary.md#container-namespacetarget and updates thecapabilitieslocation to catch up with #329.