config-solaris.md: fix info #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hqhq
reviewed
May 9, 2017
config-solaris.md
Outdated
| @@ -26,7 +26,7 @@ The property should consist of a comma-separated privilege set specification as | |||
| ## <a name="configSolarisMaxShmMemory" />maxShmMemory | |||
| The maximum amount of shared memory allowed for this application container. | |||
| A scale (K, M, G, T) can be applied to the value for each of these numbers (for example, 1M is one megabyte). | |||
| Mapped to `max-shm-memory` in [zonecfg(1M)][zonecfg.1m] man page. | |||
| Mapped to `max-shm-memory` in [zonecfg(1M)][zonecfg.1m_2] man page. | |||
There was a problem hiding this comment.
I got 404 error from this link, I think the right link is: https://docs.oracle.com/cd/E36784_01/html/E36871/zonecfg-1m.html
And I think it makes more sense to use alias zonecfg.1m for this link.
There was a problem hiding this comment.
And I think it makes more sense to use alias
zonecfg.1mfor this link.
You need to use zonecfg.1m_2 to follow our policy and avoid conflicts with the config.md entry.
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
These were added in f9dc90b (make link usage consistent across the specification, 2017-08-09, opencontainers#687) to follow the new _N name-dedup policy discussed in style.md. They were removed in ea65eb3 (config-solaris.md: fix info, 2017-04-28, opencontainers#786), overlooking that policy. This commit brings them back. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
With the same link update that config-solaris.md got in ea65eb3 (config-solaris.md: fix info, 2017-04-28, opencontainers#786), since the old link 404s. Signed-off-by: W. Trevor King <wking@tremily.us>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com