schema: Add a range limit to Swappiness #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
On Mon, Apr 24, 2017 at 10:48:20PM -0700, Zhou Hao wrote:
https://github.com/opencontainers/runtime-spec/blame/master/specs-go/config.go#L296
The Go comments are not normative [1], so you cannot use them as
grounds for validation. We could bring that range limit into the
normative Markdown of config-linux.md, but the current maintainer
position seems to be against carrying kernel limits (e.g. see #755).
On the other hand, the spec isn't particularly consistent about
whether it carries kernel limits (e.g. it has them in [2,3,4,…]), so
maybe maintainers will want to carry this one.
[1]: https://github.com/opencontainers/runtime-spec/blame/v1.0.0-rc5/config.md#L4
[2]: https://github.com/opencontainers/runtime-spec/blame/4754b55de94f6559f32589858d4027ee7bf61a5a/config-linux.md#L114
[3]: https://github.com/opencontainers/runtime-spec/blame/4754b55de94f6559f32589858d4027ee7bf61a5a/config-linux.md#L218
[4]: https://github.com/opencontainers/runtime-spec/blame/4754b55de94f6559f32589858d4027ee7bf61a5a/config-linux.md#L355
|
|
I don't think they should be in spec, I've opened #780 to remove the remain ones. |
|
Closing since we are getting rid of tracking kernel limits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/opencontainers/runtime-spec/blame/master/specs-go/config.go#L296
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com