meeting: Add UberConference information #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And bump DTSTAMP for the touched VEVENTS. This is less DRY, but makes life easier for folks pulling up the calendar a minute before the meeting, since they don't have to click through to the README section. Also requested by Vincent [1] ;). The LOCATION entry [2] seems like a reasonable location for the conference-call page, so I've used that. Note that the URI there is a text value; LOCATION supports URIs in ALTREP [2], but the UberConference page isn't an "alternate text representation for the property value" [3]. The URI in DESCRIPTION is a fallback for clients that don't support/display LOCATION (I'm not sure if any exist, but it's easy to play it safe). I couldn't find a more structured location for the phone number, unless we also wanted to put that in LOCATION. The ICS was validated with [4]. [1]: http://ircbot.wl.linuxfoundation.org/eavesdrop/%23opencontainers/%23opencontainers.2017-04-05.log.html#t2017-04-05T17:55:25 [2]: https://tools.ietf.org/html/rfc5545#section-3.8.1.7 [3]: https://tools.ietf.org/html/rfc5545#section-3.2.1 [4]: https://icalendar.org/validator.html Signed-off-by: W. Trevor King <wking@tremily.us>
|
and since i've linked straight to raw file on master it ought to just update ;-) |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And bump
DTSTAMPfor the touchedVEVENTS.This is less DRY, but makes life easier for folks pulling up the calendar a minute before the meeting, since they don't have to click through to the README section. Also requested by @vbatts ;).
The
LOCATIONentry seems like a reasonable location for the conference-call page, so I've used that. Note that the URI there is a text value;LOCATIONsupports URIs inALTREP, but the UberConference page isn't an “alternate text representation for the property value”. The URI inDESCRIPTIONis a fallback for clients that don't support/displayLOCATION(I'm not sure if any exist, but it's easy to play it safe). I couldn't find a more structured location for the phone number, unless we also wanted to put that inLOCATION.The ICS was validated here.