Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Replace '$GOOS' with 'GOOS', etc. #753

Merged
merged 1 commit into from
Apr 5, 2017
Merged

config: Replace '$GOOS' with 'GOOS', etc. #753

merged 1 commit into from
Apr 5, 2017

Commits on Apr 4, 2017

  1. config: Replace '$GOOS' with 'GOOS', etc. 

    Windows' cmd.exe prefers wrapping in % (e.g. %GOOS%) [1], and Rob
Dolin has asked for the POSIX $ to be removed [2].  In this case, I
think the context is sufficient that we can just use the variable name
instead of Rob's recommended "for the environment variable FOO".

[1]: https://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/ntcmds_shelloverview.mspx?mfr=true
[2]: opencontainers#477 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    124a819 View commit details
    Browse the repository at this point in the history