Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: E.123 number for meeting call #748

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 29, 2017

And fix a period/paren swap. The period/paren swap and contry-code addition both bring the local version more in line with the image-spec version and seem like good changes.

I've diverged from the image-spec version by using space separation in the phone number instead of hyphens. From E.123:

9.1 Grouping of digits in a telephone number⁵ should be accomplished by means or spaces⁶ unless an agreed upon explicit symbol (e.g. hyphen) is necessary for procedural purposes. Only spaces should be used in an international number.

And fix a period/paren swap.  The period/paren swap and contry-code
addition both bring the local version more in line with the image-spec
version [1] and seem like good changes.

I've diverged from the image-spec version by using space separation in
the phone number instead of hyphens.  From E.123 [2,3]:

  9.1  Grouping of digits in a telephone number [5] should be
  accomplished by means or spaces [6] unless an agreed upon explicit
  symbol (e.g. hyphen) is necessary for procedural purposes. Only
  spaces should be used in an international number.

[1]: https://github.com/opencontainers/image-spec/blob/v1.0.0-rc5/README.md#weekly-call
[2]: http://www.itu.int/rec/T-REC-E.123/en
[3]: https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-E.123-200102-I!!PDF-E&type=items

Signed-off-by: W. Trevor King <wking@tremily.us>
@hqhq
Copy link
Contributor

hqhq commented Apr 5, 2017

LGTM

Approved with PullApprove

1 similar comment
@vbatts
Copy link
Member

vbatts commented Apr 5, 2017

LGTM

Approved with PullApprove

@vbatts vbatts merged commit e8a0d3d into opencontainers:master Apr 5, 2017
@wking wking deleted the meeting-copy-edit branch April 5, 2017 16:20
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants