runtime-linux: Condition /proc/self/fd symlinks on source existence #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 279c3c0 (linux: relax filesystem requirements for container, 2017-01-23, opencontainers#666) it's no longer guaranteed that /proc will exist. And there doesn't seem to be much point in requiring symlinks which will be known broken. This commit also tightens the timing. Before it was just "after the container has `/proc` mounted", which could have happened during the 'delete' operation (if the container authors wanted to be especially ornery). With this commit, I've put the creation in step 2 of the lifecycle. And within step 2, it happens after 'mounts' has been processed. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
dev-symlink-conditional
branch
from
b6f1200 to
3aa9eb8
Compare
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #666 it's no longer guaranteed that
/procwill exist. And there doesn't seem to be much point in requiring symlinks which will be known broken.This commit also tightens the timing. Before it was just “after the container has
/procmounted”, which could have happened during thedeleteoperation (if the container authors wanted to be especially ornery). With this commit, I've put the creation in step 2 of the lifecycle. And within step 2, it happens aftermountshas been processed.