Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Drop "not supported by the base OS" loophole #733

Conversation

wking
Copy link
Contributor

@wking wking commented Mar 16, 2017

All of these operations should be supported on all of our compliance-tested platforms. If there are cases where a given OS cannot support one of these operations, it should be discussed in that operation's section, and the "Unless otherwise stated" qualifier makes space for that. But leaving the reader to decide on whether a host OS supports a given operation seems too unstable for a specification.

I've also dropped the "OCI compliant" qualifier, because the (not) compliant language in spec.md already ties OCI compliance to the RFC 2119 language. There's no point in mentioning "OCI compliant" outside of that section, because the "MUST" already brings in all of the compliance associations we need.

All of these operations should be supported on all of our
compliance-tested platforms.  If there are cases where a given OS
cannot support one of these operations, it should be discussed in that
operation's section, and the "Unless otherwise stated" qualifier makes
space for that.  But leaving the reader to decide on whether a host OS
supports a given operation seems too unstable for a specification.

I've also dropped the "OCI compliant" qualifier, because the (not)
compliant language in spec.md already ties OCI compliance to the RFC
2119 language.  There's no point in mentioning "OCI compliant" outside
of that section, because the "MUST" already brings in all of the
compliance associations we need.

Signed-off-by: W. Trevor King <wking@tremily.us>
@crosbymichael
Copy link
Member

crosbymichael commented May 10, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented May 10, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 57428ed into opencontainers:master May 10, 2017
@wking wking deleted the remove-base-operating-system-loophole branch May 10, 2017 23:51
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants