-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make path to bundle optional #447
Conversation
Make it optional looks reasonable to me, and it's what we do in runc now. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
On Mon, May 23, 2016 at 02:31:56AM -0700, Qiang Huang wrote:
These sketches are not intended to be a command-line API 1. I think |
@hqhq i think this is just an error in the docs, it is a flag on the runtime and has always been a flag. I think its safe to just remove this for now as it was never the case. |
On Mon, May 23, 2016 at 12:57:55PM -0700, Michael Crosby wrote:
What was never the case? The runtime does need to know which |
Oh, I see. This is not specifying a CLI but just specifying the inputs to the start action. If we look at it that way then bundle path is required even though most runtimes will imply the bundle path is the |
On Mon, May 23, 2016 at 01:15:23PM -0700, Michael Crosby wrote:
That's how I've been looking at it based on 1, but a few folks have |
Replace: opencontainers#447 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Replace: opencontainers#447 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Make it optional looks reasonable to me, and it's what
we do in runc now.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com