Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Make mount options format per-platform #439

Closed
wants to merge 1 commit into from

Conversation

RobDolinMS
Copy link
Collaborator

The fstab format (https://wiki.archlinux.org/index.php/Fstab) may be appropriate for Linux, but may not be appropriate for other OS platforms.

This edit clarifies that mount options for Linux (and Solaris per @JLB13) MUST be in fstab format but leaves the format of options as open for other operating systems to clarify.

This replaces PR #432

Signed-off-by: Rob Dolin RobDolin@microsoft.com

The fstab format (https://wiki.archlinux.org/index.php/Fstab) may be appropriate for Linux, but may not be appropriate for other OS platforms.

This edit clarifies that mount options for Linux (and Solaris per @JLB13) MUST be in fstab format but leaves the format of options as open for other operating systems to clarify. 

This replaces PR opencontainers#432

Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
@wking
Copy link
Contributor

wking commented May 18, 2016

On Wed, May 18, 2016 at 11:51:26AM -0700, Rob Dolin (MSFT) wrote:

The fstab format (https://wiki.archlinux.org/index.php/Fstab) may be
appropriate for Linux, but may not be appropriate for other OS
platforms.

50532d0 looks fine to me. I can file a change to link the man page
1 in a subsequent PR 2.

@jlbutler
Copy link
Member

I don't think we should call out an explicit must for Solaris to use a format defined for Linux. My comment was meant to indicate something like the existing format would be fine for Solaris. This wasn't meant to map explicitly to a requirement related to fstab format (which seems to be related to vfstab in Solaris). I'd be happy just leaving the bit about it for Linux, and other platforms can define their own formats.

Speaking of, should each OS have its own definition in this space? It seems like we could either use the platform section or have a platform label as part of the mount specification.

@wking
Copy link
Contributor

wking commented May 18, 2016

On Wed, May 18, 2016 at 12:25:37PM -0700, Jesse Butler wrote:

… which seems to be related to vfstab in Solaris…

Can you give a link to the vfstab docs? Or whatever the spec is
behind Solaris' support for this field?

Speaking of, should each OS have its own definition in this space?
It seems like we could either use the platform section or have a
platform label as part of the mount specification.

This came up briefly again in today's meeting. Here's my recording of
@mrunalp's position 1. I expect this falls (with process.uid and
such) under the “don't namespace for unspecified asthetic reasons”.
Although I'm probably biased, since I'd rather not namespace any
settings.

@jlbutler
Copy link
Member

jlbutler commented May 18, 2016

I mentioned vfstab in passing, we would likely not use that. We would likely use the filesystem (or 'fs') resource in zonecfg for Solaris. This is discussed in our documentation in various places (This[1] seems to be about the best place to hang a hat that I can find at the moment).

If it's helpful, the abstract configuration looks something like this for a given mount:

fs $identifier:
dir: $guest_mnt_point
special: $host_path
type: $fs_type
options: [fs options, per type]

[1] http://docs.oracle.com/cd/E53394_01/html/E54752/z.admin.ov-2.html#VLZSOz.admin.ov-26

@wking
Copy link
Contributor

wking commented May 19, 2016

On Wed, May 18, 2016 at 04:59:40PM -0700, Jesse Butler wrote:

This1 seems to be about the best place to hang a hat that I can find at the moment

1 http://docs.oracle.com/cd/E53394_01/html/E54752/z.admin.ov-2.html#VLZSOz.admin.ov-26

That doesn't talk much about which (filesystem-dependent) options are
supported. Stumbling around blindly for a but turned up mount(1m)
1, which lists a few option ((no)devices, (no)exec, …). This seems
similar to fstab(5)'s list of basic filesystem options 2, which
lists ro, rw, defaults, noauto, user, owner, … and points at mount(8)
and swapon(8) for more details, and mount(8) has the meat in [3,4].

@tianon
Copy link
Member

tianon commented Nov 4, 2016

Is this PR still relevant?

In current master, this appears to already be resolved sufficiently to cover the goals of this PR:

* **`options`** (list of strings, OPTIONAL) Mount options of the filesystem to be used.
  Linux: [supported][mount.8-filesystem-independent] [options][mount.8-filesystem-specific] are listed in [mount(8)][mount.8].

@wking
Copy link
Contributor

wking commented Nov 4, 2016

On Fri, Nov 04, 2016 at 03:12:53PM -0700, Tianon Gravi wrote:

Is this PR still relevant?

+1 to closing this as “fixed by #443”.

@hqhq
Copy link
Contributor

hqhq commented Nov 10, 2016

Fixed by #443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants