runtime: Explicitly allow 'start' to not validate config.json #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
optional-start-validation
branch
from
4a84bdc
to
d7b5e15
Compare
This spec places RFC-2119 requirements on both bundles (bundle.md, config.md, ...) and runtimes (runtime.md, runtime-linux.md). While it's possible to envision a system where bundle validation is required before container setup begins, it is also possible to decoupled validation and allow the runtime to blindly stumble through as far as it can. We already link to ocitools and OCT for testing both runtimes and bundles [1], so users interested in pre-start validation can use those tools. This commit explicitly documents the non-requirement and links to those tools, to make life less surprising for everybody. [1]: https://github.com/opencontainers/runtime-spec/blob/v0.5.0/implementations.md#testing--tools Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
This was referenced May 20, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec places RFC-2119 requirements on both bundles (bundle.md,
config.md, ...) and runtimes (runtime.md, runtime-linux.md). While
it's possible to envision a system where bundle validation is required
before container setup begins, it is also possible to decoupled
validation and allow the runtime to blindly stumble through as far as
it can.
We already link to ocitools and OCT for testing both runtimes and
bundles, so users interested in pre-start validation can use those
tools.
This commit explicitly documents the non-requirement and links to
those tools, to make life less surprising for everybody.
This is the decoupled alternative to #404.