Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-config: Require serial hook execution #265

Closed
wants to merge 1 commit into from

Commits on Dec 11, 2015

  1. runtime-config: Require serial hook execution

    Extend [1,2,3] to avoid:
    
      hook 1: spawn ---------------> reaped
      hook 2:       spawn ----------------> reaped
      hook 3:             spawn -----> reaped
    
    and explicitly require:
    
      hook 1: spawn --> reaped
      hook 2:                  spawn --> reaped
      hook 3:                                   spawn --> reaped
    
    Folks who do want parallel execution are free to use a parallelizing
    wrapper:
    
      hook 1: spawn ---------------------------> reaped
                    child 1 -----> reaped
                      child 2 ---------> reaped
                        child 3 ---> reaped
    
    Although that cuts both ways (with parallel hooks, folks could always
    use a single hook with a serializing wrapper).  Still, I'd guess most
    current implementations are already taking the serialized approach, so
    it makes bundle-author life easier if we are explicit about that.
    
    [1]: opencontainers#20 (comment)
    [2]: opencontainers#156
    [3]: opencontainers#157
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed Dec 11, 2015
    Configuration menu
    Copy the full SHA
    330223b View commit details
    Browse the repository at this point in the history