Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.1.0-rc.1 #1175

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Release v1.1.0-rc.1 #1175

merged 3 commits into from
Feb 1, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jan 24, 2023 •
edited
Loading

Call for vote: https://groups.google.com/a/opencontainers.org/g/dev/c/fnCiFoXBsiI/m/1jQm5OArBAAJ
Closes Tue Jan 31 10:25:29 AM UTC 2023

Breaking changes (but rather conforms to the existing runc implementation)

Deprecations

Additions

Minor fixes and documentation

@AkihiroSuda AkihiroSuda requested a review from a team January 24, 2023 10:21
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Closed
giuseppe
giuseppe approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbatts
vbatts approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕

thaJeztah
thaJeztah approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thaJeztah
Copy link
Member

Probably should be -rc.1 (period between rc and 1 to be proper SemVer (see opencontainers/runc#2399 for the fun facts), although I don't expect we end up with 10+ RCs (at least; I hope not!)

@AkihiroSuda
ChangeLog: Document changes since v1.0.2
f790b68 
Through 5cfc4c3 (2023-01-24)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: release v1.1.0-rc.1
3e013c2 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: v1.1.0-rc.1-dev
c42f9ae 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title Release v1.1.0-rc1 Release v1.1.0-rc.1 Jan 25, 2023
@AkihiroSuda
Copy link
Member Author

Probably should be -rc.1 (period between rc and 1 to be proper SemVer (see opencontainers/runc#2399 for the fun facts), although I don't expect we end up with 10+ RCs (at least; I hope not!)

Updated, and also reorganized the changelog (https://github.com/AkihiroSuda/runtime-spec/compare/62e5c4d1941898a1298d3a0e55173bbc04836439..c42f9ae5ccbb52ae4905eef4e15985620d902224)

thaJeztah
thaJeztah approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! still LGTM

tianon
tianon approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(and tagging 3e013c2 LGTM, for the avoidance of doubt 👍)

kolyshkin
kolyshkin approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 26, 2023
Merged
@AkihiroSuda
Copy link
Member Author

The voting will close soon (Tue Jan 31 10:25:29 AM UTC 2023).
cc @crosbymichael @cyphar @dqminh .

@vbatts May I merge this and make a release by myself, or do you plant to do that?

@AkihiroSuda
Copy link
Member Author

  • Voters: 10 (11 maintainers minus myself)
  • Actual votes: 7
  • Approvals: 7

Let me merge this and make a release

@AkihiroSuda AkihiroSuda merged commit 0ff8cd9 into opencontainers:main Feb 1, 2023
@AkihiroSuda
Copy link
Member Author

https://github.com/opencontainers/runtime-spec/releases/tag/v1.1.0-rc.1

@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 15, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 28, 2023
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request May 22, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hqhq hqhq hqhq approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon tianon approved these changes

@giuseppe giuseppe giuseppe approved these changes

@vbatts vbatts vbatts approved these changes

@mrunalp mrunalp mrunalp approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@AkihiroSuda @thaJeztah @mrunalp @vbatts @giuseppe @tianon @kolyshkin @hqhq