Skip to content

Commit

Permalink
Fix camelCasing on idType to align with other Windows spec conventions
Browse files Browse the repository at this point in the history
Signed-off-by: Craig Wilhite <crwilhit@microsoft.com>
  • Loading branch information
cwilhit committed Jul 10, 2018
1 parent da8adc9 commit 65fac2b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions config-windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The Windows container specification uses APIs provided by the Windows Host Compu
Each entry has the following structure:

* **`id`** *(string, REQUIRED)* - specifies the device which the runtime MUST make available in the container.
* **`id_type`** *(string, REQUIRED)* - tells the runtime how to interpret `id`. Today, Windows only supports a value of `class`, which identifies `id` as a [device interface class GUID][interfaceGUID].
* **`idType`** *(string, REQUIRED)* - tells the runtime how to interpret `id`. Today, Windows only supports a value of `class`, which identifies `id` as a [device interface class GUID][interfaceGUID].

[interfaceGUID]: https://docs.microsoft.com/en-us/windows-hardware/drivers/install/overview-of-device-interface-classes

Expand All @@ -37,11 +37,11 @@ Each entry has the following structure:
"devices": [
{
"id": "24E552D7-6523-47F7-A647-D3465BF1F5CA",
"id_type": "class"
"idType": "class"
},
{
"id": "5175d334-c371-4806-b3ba-71fd53c9258d",
"id_type": "class"
"idType": "class"
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions schema/defs-windows.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"id": {
"type": "string"
},
"id_type": {
"idType": {
"type": "string",
"enum": [
"class"
Expand All @@ -15,7 +15,7 @@
},
"required": [
"id",
"id_type"
"idType"
]
}
}
Expand Down
2 changes: 1 addition & 1 deletion specs-go/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ type WindowsDevice struct {
// Device identifier: interface class GUID, etc.
ID string `json:"id"`
// Device identifier type: "class", etc.
IDType string `json:"id_type"`
IDType string `json:"idType"`
}

// WindowsResources has container runtime resource constraints for containers running on Windows.
Expand Down

0 comments on commit 65fac2b

Please sign in to comment.