Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] join the cgroup after the initial setup finished #4439

Open
wants to merge 2 commits into
base: release-1.1
Choose a base branch
from

Commits on Oct 13, 2024

  1. join the cgroup after the initial setup finished

    We should join the cgroup after the initial setup finished,
    but before runc init clone new children processes. (opencontainers#4427)
    Because we should try our best to reduce the influence of
    memory cgroup accounting from all runc init processes
    before we start the container init process.
    
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    34f1d3b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Revert opencontainers#4423 "increase memory.max in cgroups.bats"

    As we will fix the race between binary clone and cgroup join, we can eliminate the
    impacts of memory accounting from ensure_clone_binary. So runc will support lower memory
    useage the same as before.
    
    This reverts commit 719e2bc.
    
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e52d0d1 View commit details
    Browse the repository at this point in the history