Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct: Signal: honor RootlessCgroups #4395

Merged
merged 1 commit into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. libct: Signal: honor RootlessCgroups

    `signalAllProcesses()` depends on the cgroup and is expected to fail
    when runc is running in rootless without an access to the cgroup.
    
    When `RootlessCgroups` is set to `true`, runc just ignores the error
    from `signalAllProcesses` and may leak some processes running.
    (See the comments in PR 4395)
    In the future, runc should walk the process tree to avoid such a leak.
    
    Note that `RootlessCgroups` is a misnomer; it is set to `false` despite
    the name when cgroup v2 delegation is configured.
    This is expected to be renamed in a separate commit.
    
    Fix issue 4394
    
    Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
    AkihiroSuda committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    429e06a View commit details
    Browse the repository at this point in the history