Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Fix setting RLIMIT_NOFILE #4239

Closed
wants to merge 3 commits into from
Closed

[1.1] Fix setting RLIMIT_NOFILE #4239

wants to merge 3 commits into from

Commits on Apr 2, 2024

  1. update go version to 1.21 in cirrus ci 

    Signed-off-by: lfbzhm <lifubang@acmcoder.com>
(cherry picked from commit a596a05)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @lifubang @kolyshkin
    lifubang authored and kolyshkin committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4d5f4d4 View commit details
    Browse the repository at this point in the history

  2. ci/gha/cross-i386: pin Go to 1.21 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2e44b8f View commit details
    Browse the repository at this point in the history

  3. [1.1] Fix setting RLIMIT_NOFILE 

    Since Go 1.21 (https://go-review.googlesource.com/c/go/+/476097), Go
runtime saves the original value of RLIMIT_NOFILE upon startup and uses
the saved value in StartProcess, unless RLIMIT_NOFILE is not explicitly
changed by calling syscall.Setrlimit.

Now, runc uses unix.Prlimit (rather than syscall.Setrlimit) to set
RLIMIT_NOFILE, thus Golang runtime is not aware that it is changed,
result in occasional reset of RLIMIT_NOFILE, reported in opencontainers#4195.

Bumping x/sys/unix to v0.7.0 fixes this (via
https://go-review.googlesource.com/c/sys/+/476695).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ec70039 View commit details
    Browse the repository at this point in the history