Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libct/cg/dev: skip flaky test of CentOS 7 #3778

Merged
merged 1 commit into from
Mar 27, 2023
Merged

libct/cg/dev: skip flaky test of CentOS 7 #3778

merged 1 commit into from
Mar 27, 2023

Conversation

kolyshkin
Copy link
Contributor

There is some kind of a race in CentOS 7 which sometimes result in one of these tests failing like this:

systemd_test.go:136: mkdir /sys/fs/cgroup/hugetlb/system.slice/system-runc_test_pods.slice: no such file or directory

or

systemd_test.go:187: open /sys/fs/cgroup/cpuset/system.slice/system-runc_test_pods.slice/cpuset.mems: no such file or directory

As this is only happening on CentOS 7, let's skip this test on this platform.

Fixes: #3743

@kolyshkin
libct/cg/dev: skip flaky test of CentOS 7
a7a836e 
There is some kind of a race in CentOS 7 which sometimes result in one
of these tests failing like this:

    systemd_test.go:136: mkdir /sys/fs/cgroup/hugetlb/system.slice/system-runc_test_pods.slice: no such file or directory

or

    systemd_test.go:187: open /sys/fs/cgroup/cpuset/system.slice/system-runc_test_pods.slice/cpuset.mems: no such file or directory

As this is only happening on CentOS 7, let's skip this test on this
platform.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

It works:

=== RUN   TestSkipDevicesTrue
    systemd_test.go:128: Flaky on CentOS 7
--- SKIP: TestSkipDevicesTrue (0.03s)
=== RUN   TestSkipDevicesFalse
    systemd_test.go:128: Flaky on CentOS 7
--- SKIP: TestSkipDevicesFalse (0.03s)

@kolyshkin kolyshkin marked this pull request as ready for review March 27, 2023 16:19
@kolyshkin kolyshkin added easy-to-review backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Mar 27, 2023
@kolyshkin
Copy link
Contributor Author

@thaJeztah PTAL (easy to review one)

@kolyshkin
Copy link
Contributor Author

centos-stream-9 CI failures is a different issue and is addressed by #3782

thaJeztah
thaJeztah approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Went looking if we could make it "pass" if it fails on CentOS 7, but looks like that requires multiple t.Fatal() to be updated, so probably not worth the effort)

mrunalp
mrunalp approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit 3e3db28 into opencontainers:main Mar 27, 2023
@kolyshkin kolyshkin mentioned this pull request Apr 3, 2023
Merged
@kolyshkin
Copy link
Contributor Author

1.1 backport: #3807

@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@mrunalp mrunalp mrunalp approved these changes

Assignees
No one assigned
Labels
area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review
Projects
None yet
Milestone
No milestone
3 participants
@kolyshkin @mrunalp @thaJeztah