Add SCMP_ACT_TRACE as a valid Seccomp action #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables tracing of blocked system calls in a container for debugging purposes. Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
This defaults to using EPERM as its signal, to match ACT_ERRNO. Looking into making that configurable in the runc spec, hopefully will have a PR out for that by end of today. |
| @@ -33,9 +33,10 @@ type Seccomp struct { | |||
| type Action int | |||
|
|
|||
| const ( | |||
| Kill Action = iota - 4 | |||
There was a problem hiding this comment.
why not do it like this ?
const (
Kill Action = iota
Errno
Trap
Allow
Trace
)
There was a problem hiding this comment.
This way, uninitialized Action variables will not be a valid constant, and will cause an error
There was a problem hiding this comment.
just like the define of "EqualTo Operator", I do think it has problem,Maybe the error caused by other. It doesn't matter all the same,just a surgestion. thanks for your reply.
crosbymichael
added a commit
to crosbymichael/runc
that referenced
this pull request
Nov 13, 2015
Closes opencontainers#347 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
config: clarify the uname mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables tracing of blocked system calls in a container. This could be useful for debugging, and is the only Seccomp action runc doesn't support at present.