Recursively look for PIDs in cgroups #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the cgroup fs the GetPids() should return pids of child cgroups also. Fixes moby/moby#16206 Signed-off-by: Darren Shepherd <darren@rancher.com>
|
I've been running this patch for awhile in RancherOS with no issue. I've held off on submitting it but I could never figure how to write a test in runc. But I really need this fix for Docker 1.9. |
|
@ibuildthecloud and how would the cgroups get into this type of state that you need to do this? |
|
@crosbymichael Docker in Docker. Each level of docker just nests more and more. Nobody ever notices there is a problem because they don't do |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Move process specific settings to process
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
These slipped through in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <wking@tremily.us>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
The label changed in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329) and 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276) missed this instance when rebasing around opencontainers#329. Signed-off-by: W. Trevor King <wking@tremily.us>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Since f9dc90b (make link usage consistent across the specification, 2017-02-09, opencontainers#687), the official style is to only use reference-style links for external links. I expect the remaining three entries just slipped through. This commit adjusts everything found with: $ git grep ']: [a-z]' | grep -v http It also fixes the underscore -> hyphen in the glossary.md#container-namespace target and updates the capabilities location to catch up with 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the cgroup fs the GetPids() should return pids of child
cgroups also.
Fixes moby/moby#16206
Signed-off-by: Darren Shepherd darren@rancher.com