Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pullapprove integration config #2442

Merged
merged 1 commit into from
May 30, 2020
Merged

Remove pullapprove integration config #2442

merged 1 commit into from
May 30, 2020

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 29, 2020 •
edited
Loading

Fixes #2388

This is in addition to

  • removing the repo from pullapprove
  • removing the pullapprove webhook

which was already done by me.

@kolyshkin
Remove pullapprove integration
0f3d6be 
Fixes opencontainers#2388

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin changed the title Remove pullapprove integration Remove pullapprove integration config May 29, 2020
mrunalp
mrunalp approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AkihiroSuda
AkihiroSuda approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyphar
cyphar approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar merged commit e664e73 into opencontainers:master May 30, 2020
@h-vetinari h-vetinari mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cyphar cyphar cyphar approved these changes

@mrunalp mrunalp mrunalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[proposal/rfc] Use github-native review process, say goodbye to pullapprove
4 participants
@kolyshkin @mrunalp @cyphar @AkihiroSuda