-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for criuProcess once #2420
Conversation
if err != nil {
return
} in the
|
@avagin PTAL |
w.r.t. #1, I have updated the PR to log the error. |
Ping @avagin |
LGTM |
@AkihiroSuda @mrunalp PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In linuxContainer#criuSwrk(), the deferred func may wait on criuProcess for a second time, if the following has been executed (around line 1640):
This PR adds check for st so that there is no redundant wait.
Note: there is already deferred criuClientCon.Close() on line 1476