Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster mountinfo parser #2255

Closed
wants to merge 5 commits into from
Closed

Faster mountinfo parser #2255

wants to merge 5 commits into from

Commits on Mar 13, 2020

  1. libcontainer/mount: faster implementation from Moby 

    Commit 3ca4c78 drops the Moby (then Docker) pkg/mount
code here, and it was mostly forgotten since.

In the meantime, Moby's mountinfo parser has much improved,
and this commit brings it here.

The new parser deliberately changes the API, so its users are
converted accordingly.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    92eb2a0 View commit details
    Browse the repository at this point in the history

  2. libct/TestFactoryNewTmpfs: benefit from GetMounts 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    226911b View commit details
    Browse the repository at this point in the history

  3. getParentMount: benefit from GetMounts filter 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    0746b8c View commit details
    Browse the repository at this point in the history

  4. libct/msMoveRoot: rm redundant filepath.Abs() calls 

    1. rootfs is already validated to be kosher by (*ConfigValidator).rootfs()

2. mount points from /proc/self/mountinfo are absolute and clean, too

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    b65e6e1 View commit details
    Browse the repository at this point in the history

  5. libct/msMoveRoot: benefit from GetMounts filter 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    8c635d2 View commit details
    Browse the repository at this point in the history