Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcontainer/specconv/spec_linux: Support empty 'type' for bind mounts #1753

Merged
merged 1 commit into from
Apr 16, 2018
Merged

libcontainer/specconv/spec_linux: Support empty 'type' for bind mounts #1753

merged 1 commit into from
Apr 16, 2018
+28 −3

Commits on Mar 7, 2018

  1. libcontainer/specconv/spec_linux: Support empty 'type' for bind mounts 

    From the "Creating a bind mount" section of mount(2) [1]:

> If mountflags includes MS_BIND (available since Linux 2.4), then
> perform a bind mount...
>
> The filesystemtype and data arguments are ignored.

This commit adds support for configurations that leave the OPTIONAL
type [2] unset for bind mounts.  There's a related spec-example change
in flight with [3], although my personal preference would be a more
explicit spec for the whole mount structure [4].

[1]: http://man7.org/linux/man-pages/man2/mount.2.html
[2]: https://github.com/opencontainers/runtime-spec/blame/v1.0.1/config.md#L102
[3]: opencontainers/runtime-spec#954
[4]: opencontainers/runtime-spec#771

Signed-off-by: W. Trevor King <wking@tremily.us>
    @wking
    wking committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    0aa6e4e View commit details
    Browse the repository at this point in the history