Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding go get instruction to readme #1729

Merged
merged 1 commit into from
Feb 22, 2018
Merged

adding go get instruction to readme #1729

merged 1 commit into from
Feb 22, 2018

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Feb 21, 2018

Trying this again... so very hard...

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@crosbymichael
Copy link
Member

crosbymichael commented Feb 21, 2018

LGTM

Approved with PullApprove

@vsoch
Copy link
Contributor Author

vsoch commented Feb 21, 2018

Silly question - do you know how to change the automatic signature? Mine automatically appears like this when I add the -s to the commit:

Signed-off-by: vsoch <vsochat@stanford.edu>

And Google searching, as is the case with anything with "Github" returns a bunch of Github repositories that don't answer my question. The closest I figured out was that it has something to do with the GPG key documentation, and I am guessing that there is a setting somewhere that needs to be edited, although I didn't find it. I'm also happy to sign and then amend the commit to make it have my full name. What is your strategy?

@crosbymichael
Copy link
Member

@vsoch
Copy link
Contributor Author

vsoch commented Feb 21, 2018

Beautiful! Thank you @crosbymichael

@hqhq
Copy link
Contributor

hqhq commented Feb 22, 2018

LGTM

Approved with PullApprove

@hqhq hqhq merged commit e59b6d4 into opencontainers:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants