libcontainer: expose annotations in hooks #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure is #1682 |
Annotations weren't passed to hooks. This patch fixes that by passing annotations to stdin for hooks. Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
annotations-hooks
branch
from
d80c43d
to
cd1e7ab
Compare
|
rebased to handle tests failure |
|
I've filed spec backing for this approach in opencontainers/runtime-spec#946. |
|
LGTM. |
|
@mrunalp @crosbymichael PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations weren't passed to hooks. This patch fixes that by passing
annotations to stdin for hooks.
Fix #1686
/cc @mrunalp @FlorianOtel
Signed-off-by: Antonio Murdaca runcom@redhat.com