Avoid disk usage explosion when copying busybox #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
|
@crosbymichael hmm travis hadnt run here yet. Wait for it before merging |
|
Not sure why travis is not running, I tried reopening to bump it but nothing. Humm... |
|
According to https://travis-ci.org/opencontainers/runc/requests, "Abuse detected" 😕 |
|
@tianon This happened recently to a PR made to containers/image. An email to travis support and they were able to remove this "abuse" marker. I can email them in a few hours when I'm home. |
|
👍 |
|
@crosbymichael could you try opening and closing again please? I've contacted Travis and they've marked our org as not abusive :) |
When running runc tests with temp directory with size 500M copying busybox without preserving hardlinks causes the folder to inflate to roughly 330M. Copying busybox twice in certain tests causes the /tmp directory to overfill. Using `-a` preserves links which busybox uses to implement its choice of binary to run. Signed-off-by: Tom Godkin <tgodkin@pivotal.io>
danail-branekov
force-pushed
the
busybox-inflation
branch
from
a403e9e to
fdbb9e3
Compare
|
@dqminh @crosbymichael We've force pushed an empty commit to re-trigger Travis and it's gone green :) Looks like the "LGTM"s have reset as a side effect. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running runc tests with temp directory with size 500M, copying
busybox without preserving hardlinks causes the folder to inflate to
roughly 330M. Copying busybox twice in certain tests causes the /tmp
directory to overfill. Using
-apreserves links which busybox uses toimplement its choice of binary to run.
Signed-off-by: Tom Godkin tgodkin@pivotal.io