Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cgroups earlier #1586

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Conversation

crosbymichael
Copy link
Member

This applies cgroups earlier for container creation before the init
process starts running and forking off any additional processes.

Signed-off-by: Michael Crosby crosbymichael@gmail.com

This applies cgroups earlier for container creation before the init
process starts running and forking off any additional processes.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@dqminh
Copy link
Contributor

dqminh commented Sep 7, 2017

LGTM

Approved with PullApprove

@hqhq
Copy link
Contributor

hqhq commented Sep 12, 2017

LGTM @crosbymichael Did you encounter any bug? It won't change anyghing as the internal processes runc-init creates would be exited when we do Apply, and it might slightly impact resource consumption which might not be expected by users, but I noticed that containerd has moved shim process into container cgroup, so it'll be less a problem when users realized that fact.

Approved with PullApprove

@hqhq hqhq merged commit 68e00e9 into opencontainers:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants