Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoDedup option to CriuOpts #1561

Merged
merged 2 commits into from
Aug 18, 2017

Conversation

thegrumpylion
Copy link
Contributor

Memory image deduplication, very useful for incremental dumps.

See: https://criu.org/Memory_images_deduplication

Signed-off-by: Nikolas Sepos nikolas.sepos@gmail.com

Memory image deduplication, very useful for incremental dumps.

See: https://criu.org/Memory_images_deduplication

Signed-off-by: Nikolas Sepos <nikolas.sepos@gmail.com>
@crosbymichael
Copy link
Member

Is there are newer version of criu that we should bump in our dependency list to take advantage of this?

@dqminh
Copy link
Contributor

dqminh commented Aug 18, 2017

@crosbymichael the current criu we tracked in dockerfile should already have this feature. This PR however doesn't enable autodedup anywhere though, just make it possible to have the option. Should we also add a flag to enable this in checkpoint/restore command @nseps ?

@thegrumpylion
Copy link
Contributor Author

@dqminh Currently i'm just using libcontainer directly from golang. That is why this PR just makes the option available. I plan on following this with "auto-dedup" flag for runc but feel free to add it :)

@thegrumpylion
Copy link
Contributor Author

Now that i think of it, maybe it would be better if the runc flag was part of this PR. What do you think?

@crosbymichael
Copy link
Member

@nseps ya, that works if you don't mind adding it

When doing incremental dumps is useful to use auto deduplication of
memory images to save space.

Signed-off-by: Nikolas Sepos <nikolas.sepos@gmail.com>
@dqminh
Copy link
Contributor

dqminh commented Aug 18, 2017

LGTM

Approved with PullApprove

@crosbymichael
Copy link
Member

crosbymichael commented Aug 18, 2017

LGTM

Thanks!

Approved with PullApprove

@crosbymichael crosbymichael merged commit ae29480 into opencontainers:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants