Always save own namespace paths #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is CI failure relevant? |
fix opencontainers#1476 If containerA shares namespace, say ipc namespace, with containerB, then its ipc namespace path would be the same as containerB and be stored in `state.json`. Exec into containerA will just read the namespace paths stored in this file and join these namespaces. So, if containerB has already been stopped, `docker exec containerA` will fail. To address this issue, we should always save own namespace paths no matter if we share namespaces with other containers. Signed-off-by: Yuanhong Peng <pengyuanhong@huawei.com>
yummypeng
force-pushed
the
save-own-ns-path
branch
from
56e00e7 to
e939079
Compare
|
@hqhq I have modified the testcase, and now CI is green. |
|
LGTM |
|
ping @opencontainers/runc-maintainers PTAL |
|
ping @cyphar PTAL 😜 |
|
LGTM |
runcom
added a commit
to projectatomic/runc
that referenced
this pull request
Nov 12, 2017
Fix https://bugzilla.redhat.com/show_bug.cgi?id=1510573 Upstream reference: opencontainers/runc#1477 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1476
If containerA shares namespace, say ipc namespace, with containerB, then
its ipc namespace path would be the same as containerB and be stored in
state.json. Exec into containerA will just read the namespace pathsstored in this file and join these namespaces. So, if containerB has
already been stopped,
docker exec containerAwill fail.To address this issue, we should always save own namespace paths no
matter if we share namespaces with other containers.
Signed-off-by: Yuanhong Peng pengyuanhong@huawei.com