Use opencontainers/selinux package #1365
Conversation
|
We'll need opencontainers/selinux#7 to be merged to fix CI failure. |
|
I would prefer the rename before this gets merged. |
|
@rhatdan Sure, I'll rework this PR after rename and other fixes in opencontainers/selinux are merged. |
|
Updated, all green now~ |
|
I have requested one more change to the opencontainers/selinux package to put the go bindings into a golang subdir, so we can add a policy subdir and move container-selinux package into opencontainers/selinux package. |
|
@rhatdan is upstream good now? I saw that issue is closed so are you happy with the naming of the project now so that we can update? |
|
@crosbymichael we have renamed a bunch of function calls. Lets get these merged and then we will need to change the calls in libcontainer as well as vendor it in. |
|
Upstream has been merged, we can start to convert runc to use the new interfaces. |
It's splitted as a separate project. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
@rhatdan Thanks, I'll rework later today. |
|
Updated. |
| @@ -7,7 +7,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/opencontainers/runc/libcontainer/configs" | |||
| "github.com/opencontainers/runc/libcontainer/selinux" | |||
| selinux "github.com/opencontainers/selinux/go-selinux" | |||
There was a problem hiding this comment.
@runcom says there is no need to use selinux here.
selinux "github.com/opencontainers/selinux/go-selinux"
The code should work fine without it.
There was a problem hiding this comment.
yup, there shouldn't be the need of aliasing if go-selinux exports selinux package afaict.
There was a problem hiding this comment.
I think it's an explicit or implicit issue, and I'd prefer it to be explicit, we can wait for other maintainers' opinions :)
There was a problem hiding this comment.
go-imports also makes it explicit, its fine both ways and is not an issue at all
|
LGTM |
|
ping @opencontainers/runc-maintainers |
|
LGTM |
It's splitted as a separate project.
Fixes: #897
Signed-off-by: Qiang Huang h.huangqiang@huawei.com