tests: add various !terminal tests #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this one if its still needed and you want to add these tests. |
|
Rebased. The tests fail because of a bug introduced by #1529 -- I'll work on fixing this in a bit. |
Previously we would handle the "unmapped stdio" case by just doing a simple check, however this didn't handle cases where the overflow_uid was actually mapped in the user namespace. Instead of doing some userspace checks, just try to do the fchown(2) and ignore EINVAL (unmapped) or EPERM (lacking privilege over inode) errors. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Previously we weren't testing that detached io works properly -- which will be quite important in the case for rootless containers. Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
I've fixed the rootless bug, everything works now. /cc @opencontainers/runc-maintainers |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we weren't testing that detached io works properly -- which
will be quite important in the case for rootless containers.
Signed-off-by: Aleksa Sarai asarai@suse.de