Update devices_unix.go for LXD #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarltonSemple can you sign your commit with the DCO? |
getDevices() has been updated to skip `/dev/.lxc` and `/dev/.lxd-mounts`, which was breaking privileged Docker containers running on runC, inside of LXD managed Linux Containers Signed-off-by: Carlton-Semple <carlton.semple@ibm.com>
CarltonSemple
force-pushed
the
lxd-fix
branch
from
0b8724d to
9a7e5a9
Compare
|
@crosbymichael sure thing |
CarltonSemple
force-pushed
the
lxd-fix
branch
from
d604159 to
9a7e5a9
Compare
hqhq
reviewed
Feb 17, 2017
libcontainer/devices/devices_unix.go
Outdated
| @@ -75,7 +75,7 @@ func getDevices(path string) ([]*configs.Device, error) { | |||
| switch { | |||
| case f.IsDir(): | |||
| switch f.Name() { | |||
| case "pts", "shm", "fd", "mqueue": | |||
| case "pts", "shm", "fd", "mqueue", ".lxc", ".lxd-mounts": | |||
There was a problem hiding this comment.
You better link the issue as comment, otherwise it'll be hard to understand what they are for normal runc users.
|
/ping @CarltonSemple |
Signed-off-by: Carlton-Semple <carlton.semple@ibm.com>
|
LGTM |
|
LGTM @CarltonSemple Next time you can squash your commits for such changes, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDevices() has been updated to skip
/dev/.lxcand/dev/.lxd-mounts, which was breaking privileged Docker containers running on runC inside of LXD managed Linux Containers.See https://github.com/lxc/lxd/issues/2825