libcontainer: rootfs_linux: support overlayfs #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the runtime-spec allows it, we want to be able to specify overlayfs
mounts with:
{
"destination": "/etc/pki",
"type": "overlay",
"source": "overlay",
"options": [
"lowerdir=/etc/pki:/home/amurdaca/go/src/github.com/opencontainers/runc/rootfs_fedora/etc/pki"
]
},
This patch takes care of allowing overlayfs mounts. Both RO and RW
should be supported.
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
@mrunalp @crosbymichael PTAL |
|
@runcom actually a fun thing that I have been doing is that you can also mount with the destination as |
|
yeah, maybe use runtime config directly in docker to mount the rootfs (just wondering...) |
|
LGTM |
hqhq
reviewed
Feb 8, 2017
| // this can happen when a user specifies mounts within other mounts to cause breakouts or other | ||
| // evil stuff to try to escape the container's rootfs. | ||
| var err error | ||
| if dest, err = symlink.FollowSymlinkInScope(filepath.Join(rootfs, m.Destination), rootfs); err != nil { |
There was a problem hiding this comment.
s/filepath.Join(rootfs, m.Destination)/dest?
There was a problem hiding this comment.
This is copy/pasted from the bind switch case..
There was a problem hiding this comment.
OK, we can fix that later then.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the runtime-spec allows it, we want to be able to specify overlayfs
mounts with:
This patch takes care of allowing overlayfs mounts. Both RO and RW
should be supported.
Signed-off-by: Antonio Murdaca runcom@redhat.com