-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trailing punctuation in header #1206
Conversation
Why do you remove the |
And if you're going to remove them, please change the grammar so it makes sense. |
@WeiZhang555, we don't have punctuation in head usually. @cyphar , yes, I will change them to make sense. |
@cyphar, PTAL, thanks. |
@@ -29,7 +29,7 @@ It is every maintainer's responsibility to: | |||
* 4) Make sure their component respects the philosophy, design and | |||
roadmap of the project. | |||
|
|||
## How are decisions made? | |||
## The method of making decisions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "How decisions are made" ?
I'm not a native English speaker, but to be honest, I prefer the original expression which looks more vivid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
It could be a good choice that "How to make decisions".
It is a difficult to make the sentence smoth for us.
Parts of fixing typo and removing trailing blank are good, but I prefer original expression with a "?" such as "What is expected of maintainers?" to "The expectation of maintainers", even it violates rules of some validation tools. This is only my two cents (I am not a maintainer) 😄 |
yeah, let me fix typo and remove trailing blank at first. |
Signed-off-by: yupeng <yu.peng36@zte.com.cn>
Signed-off-by: yupeng yu.peng36@zte.com.cn