Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing punctuation in header #1206

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Conversation

YuPengZTE
Copy link
Contributor

Signed-off-by: yupeng yu.peng36@zte.com.cn

@WeiZhang555
Copy link
Contributor

Why do you remove the ?

@cyphar
Copy link
Member

cyphar commented Nov 30, 2016

And if you're going to remove them, please change the grammar so it makes sense.

@YuPengZTE
Copy link
Contributor Author

@WeiZhang555, we don't have punctuation in head usually.
The tool for markdown: markdownlint check it as "MD026 no-trailing-punctuation - Trailing punctuation in header"

@cyphar , yes, I will change them to make sense.

@YuPengZTE
Copy link
Contributor Author

@cyphar, PTAL, thanks.

@@ -29,7 +29,7 @@ It is every maintainer's responsibility to:
* 4) Make sure their component respects the philosophy, design and
roadmap of the project.

## How are decisions made?
## The method of making decisions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "How decisions are made" ?

I'm not a native English speaker, but to be honest, I prefer the original expression which looks more vivid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄
It could be a good choice that "How to make decisions".
It is a difficult to make the sentence smoth for us.

@WeiZhang555
Copy link
Contributor

Parts of fixing typo and removing trailing blank are good, but I prefer original expression with a "?" such as "What is expected of maintainers?" to "The expectation of maintainers", even it violates rules of some validation tools.

This is only my two cents (I am not a maintainer) 😄

@YuPengZTE
Copy link
Contributor Author

yeah, let me fix typo and remove trailing blank at first.

Signed-off-by: yupeng <yu.peng36@zte.com.cn>
@crosbymichael
Copy link
Member

crosbymichael commented Oct 10, 2017

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Oct 20, 2017

LGTM

Approved with PullApprove

@hqhq hqhq merged commit e8b9b92 into opencontainers:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants