Remove check for binding to / #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to mount root filesystems inside the container's mount namespace as part of the spec we need to have the ability to do a bind mount to / as the destination. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
bind-root
branch
from
db41269 to
70b16a5
Compare
|
LGTM |
cyphar
reviewed
Sep 30, 2016
| if err == nil { | ||
| t.Fatal(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we keep this test anyway, as it's part of the spec?
There was a problem hiding this comment.
I mean to leave the test (just change err == nil to err != nil). In fact, we could add an integration test for mounting over / because I get the feeling there's probably quite a few places that we aren't testing with those semantics.
Not really important though, I'll LGTM this anyway.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to mount root filesystems inside the container's mount
namespace as part of the spec we need to have the ability to do a bind
mount to / as the destination.
I cannot remember why this is here specifically, I know the reasons for
/procand other paths and didn't know if we just added/just to be safe or if we had a specific reason.Signed-off-by: Michael Crosby crosbymichael@gmail.com