Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests/rootless.sh: use set -e -u -o pipefail
Currently, set -e ("exit on error") is only set before running tests. The bad consequence is the script may fail to set up test environment but will still run the tests. Use "set -e -u -o pipefail" for the whole script to catch potential issues with test setup and/or the script itself. A few caveats: 1. We have to set RUNC_USE_SYSTEMD to an empty value if it is unset, so that the subsequent checks like [ -z "$RUNC_USE_SYSTEMD" ] won't trigger a "unbound variable" error. Same for ROOTLESS_TESTPATH. 2. Functions that have code like [ -f $file ] && do_something towards the end may return 1 in case $file does not exist (as test aka [ was the last operation performed, and its exit code is returned. This is why we had to add return 0. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
- Loading branch information