Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag v1.1.0-rc.3 #1049

Merged
merged 2 commits into from
Apr 27, 2023
Merged

tag v1.1.0-rc.3 #1049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
085b884
version: bump for release of v1.1.0-rc.3
vbatts Apr 19, 2023
2f691e8
version: bump HEAD back to -dev
vbatts Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs-go/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const (
VersionPatch = 0

// VersionDev indicates development branch. Releases will be empty string.
VersionDev = "-dev"
VersionDev = "-rc.3-dev"
Copy link
Member

@cyphar cyphar Apr 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just remembered -- using -dev this way results in suboptimal behaviour with SemVer. SemVer treats 1.0.0-dev as being a pre-release of 1.0.0 -- meaning that the -dev version is seen as "older". Another issue is that -dev is not really a pre-release (and it's definitely not a pre-release of the previously-released version).

In runc and umoci we use +dev because that matches the correct version order behaviour with rpm and most other tools (1.0.1 > 1.0.0+dev > 1.0.0), though under SemVer 1.0.0+dev == 1.0.0 (I don't think this is a problem for a specification though, but maybe that's just me).

Maybe we should use +dev as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is outlined in RELEASES.md. I will submit a PR to make the change for future releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1050.

)

// Version is the specification version that the package types support.
Expand Down