address some linting issues, and small refactor, performance optimizations #103
+66
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address some linting issues
testdigest: fix package GoDoc to be in the right format
remove import aliases
RegisterAlgorithm: skip regex if not needed
No need to validate the format if we previously accepted it to be
registered.
use errors.New() for errors that don't need formatting
digestset: report allocations in benchmarks
Just for convenience ':-)
Before:
After:
remove unneeded fmt.Sprintf and indirections
Remove fmt.Sprintf and use string-concatenation instead to reduce
some allocations.
Before / After: