Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination link for extensions #336

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

sajayantony
Copy link
Member

@sajayantony sajayantony commented Aug 11, 2022

Signed-off-by: Sajay Antony sajaya@microsoft.com

Fixes #330

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
jdolitsky
jdolitsky previously approved these changes Aug 11, 2022
extensions/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.. just a little rewording

Co-authored-by: Mike Brown <brownwm@us.ibm.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably reorganize pagination around a single shared definition somewhere outside of content discovery, but that can be a future PR.

@jdolitsky jdolitsky merged commit 31efc49 into opencontainers:main Aug 12, 2022
@jdolitsky jdolitsky mentioned this pull request Sep 15, 2022
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc error: link to pagination specification is broken
4 participants