Add test for automatic cross mounting behaviour #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds conformance tests for automatic cross mounting. Usually, the test should not run as it can give a false positive. The OCI_AUTOMATIC_CROSSMOUNT must be set based on how the registry is expected to be configured. Signed-off-by: Sargun Dhillon <sargun@sargun.me>
sargun
requested review from
dmcgowan,
jdolitsky,
jonjohnsonjr,
jzelinskie,
mikebrow,
stevvooe and
vbatts
as code owners
|
"Fixes": #282 |
jdolitsky
approved these changes
Sep 17, 2021
Comment on lines
+327
to
+328
| automaticCrossmountVal, runAutomaticCrossmountTest = os.LookupEnv(envVarAutomaticCrossmount) | ||
| automaticCrossmountEnabled, _ = strconv.ParseBool(automaticCrossmountVal) |
There was a problem hiding this comment.
So if I understand correctly, the 201 test will only run if both runAutomaticCrossmountTest and automaticCrossmountEnabled are true?
and the 202 test if runAutomaticCrossmountTest is true and automaticCrossmountEnabled is false?
jonjohnsonjr
approved these changes
Sep 17, 2021
vbatts
approved these changes
Sep 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds conformance tests for automatic cross mounting. Usually, the test
should not run as it can give a false positive. The OCI_AUTOMATIC_CROSSMOUNT
must be set based on how the registry is expected to be configured.
Signed-off-by: Sargun Dhillon sargun@sargun.me