Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from Travis to GitHub Actions #284

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Move from Travis to GitHub Actions #284

merged 3 commits into from
Jun 23, 2021

Conversation

jdolitsky
Copy link
Member

No description provided.

@jdolitsky
Copy link
Member Author

Resolves #231 sorta

mikebrow
mikebrow reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

.github/workflows/build-pr.yml Show resolved Hide resolved
@mikebrow
Copy link
Member

needs rebase

@jdolitsky
Move from Travis to GitHub Actions
ad9cc95 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Member Author

@opencontainers/distribution-spec-maintainers - this is working now

mikebrow
mikebrow reviewed Jun 23, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@jdolitsky
Add newline to bottom of .gitignore
028a295 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
mikebrow
mikebrow reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on minimum version for go.mod

specs-go/go.mod Outdated Show resolved Hide resolved
@jdolitsky
use Go 1.15 as minimum version
5520b6b 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Member Author

@mikebrow - fixed in 5520b6b (the go version thing)

mikebrow
mikebrow approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 524a53f into opencontainers:main Jun 23, 2021
@jdolitsky jdolitsky mentioned this pull request Sep 15, 2022
Merged
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebrow mikebrow mikebrow approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@vbatts vbatts Awaiting requested review from vbatts

@jzelinskie jzelinskie Awaiting requested review from jzelinskie jzelinskie is a code owner

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdolitsky @mikebrow @dmcgowan