This repository has been archived by the owner on Jul 18, 2023. It is now read-only.
generated from opencontainers/project-template
-
Notifications
You must be signed in to change notification settings - Fork 54
Adding external implementations #59
Closed
sudo-bmitch
wants to merge
2
commits into
opencontainers:main
from
sudo-bmitch:pr-external-implementations
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudo-bmitch, can you help us understand the ordering of the displayed list?
If you alpha sort the displayed values, wouldn't it be:
CNCF distribution
CNCF ORAS Artifacts Spec
Docker buildkit
Google go-containerregistry/crane
OpenSSF sigstore/cosign
regclient
zot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's sorted by the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link isn't what people see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but it feels weird to change the order when something gets donated, like Docker Distribution to CNCF Distribution. Do we need to strip off the parent orgs to reduce confusion? I usually just call it Kubernetes and not CNCF Kubernetes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also help understand why this list is added to the readme.md as opposed to implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was why I was asking for a description regarding reason for link here.. a brief comment relating what each project may be doing, normally from the project owners if they would comment and/or approve the mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another .md page would be warranted if it gets tldr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm fine either way, starting here and updating in a follow up or add just enough explanation here.. to make alpha order obvious I guess just show the string being used..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're adding things, might as well also add
kosince it attaches SBOMs to images by default, using the same mechanism as cosign.As a contributor to cosign, and maintainer of crane and ko, if we think we need a little text blurb, I can propose:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have a statement from the project owner, should we remove them from the above list? My goal was to be inclusive without triggering a debate over wording of a description that would delay this getting merged.
What specific changes are being requested that would result in the project maintainers approving and merging this?