-
Notifications
You must be signed in to change notification settings - Fork 54
Collection of definitions and terms #3
Collection of definitions and terms #3
Conversation
@SteveLasker I installed PullApprove so you need to ensure you get 2 LGTMs from folks moving forward to merge changes in :) |
Yup, thanks for getting everything setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No problems here. I have a few inline nits.
4148029
to
1e96117
Compare
03be3b9
to
4154ee8
Compare
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
4154ee8
to
e011ec5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
some nits but I can push an update later, is a start :)
@caniszczyk The integration service -pull approve.. is pointing to the wrong group.. currently the image spec maintainers group. Can you please switch that over to artifacts group :-) |
@mikebrow should be fixed |
* Add pull command * Add push cmd
Signed-off-by: Steven Lasker stevenlasker@hotmail.com