-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general comment:
Thank you all for the feedback. To manage quick response time iterating on ideas to incorporate, vs. focused spec time with PRs, I'll incorporate the feedback I thumbed up next week, as well as address some of the questions that should be incorporated into the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments regarding the first few sections..
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
Signed-off-by: Steven Lasker <stevenlasker@hotmail.com>
A quick note. I've been following up with using Iana.org for the mediaType registration process. (https://www.iana.org/form/media-types) It looks very promising, with
I've registered |
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
b0b2e85
to
876538d
Compare
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Moving to the description to avoid being lost in detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments half way..
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments / questions. Mostly nits :-)
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
good first pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content in this PR looks good but the conversion of this repository into a versioned spec should be broken out. I'm not convinced the Artifacts Specification
section has actually defined a specification. The primary goals and everything after scope LGTM.
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments on the versioning/scope issue
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly word smithing (which you're free to ignore). I also had one or two clarification points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Artifacts Guidance:
This is the first of a few PRs that were tasked by the OCI TOB to serve 3 primary goals
This PR addresses how Artifact Authors utilize OCI manifest to push new artifact types to an OCI-distribution based registry.
Subsequent PRs will address
This is ready for final review: