Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the proto comments to make it clear idevid is optional #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update the proto comments to make it clear idevid is optional #48

wants to merge 1 commit into from

Conversation

melzhan
Copy link
Contributor

@melzhan melzhan commented Sep 17, 2024 •
edited
Loading

There are instances where we rotate on Google certs earlier in the workflow instead of using devid. For flexibility, make it clear that the devid is an optional field.

melzhan

This comment was marked as duplicate.

Sign in to view

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10896939594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.885%
Totals Coverage Status
Change from base Build 10087763856: 0.0%
Covered Lines: 318
Relevant Lines: 366
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcushines marcushines Awaiting requested review from marcushines marcushines is a code owner

@morrowc morrowc Awaiting requested review from morrowc morrowc is a code owner

@yvetteyuanw yvetteyuanw Awaiting requested review from yvetteyuanw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melzhan @coveralls