Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick][SAI-PTF] Add decorator for skipping test on specified error (#1609) #1625

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

richardyu-ms
Copy link
Collaborator

@richardyu-ms richardyu-ms commented Oct 24, 2022

Cherry pick from #1609
Add decorator method in the perl template for skipping test on specified error

details:

  1. add decorator method in sai_adapter_utils.tt
  2. use decorator when set parameters skip_error
  3. add parameters when building from template, like perl -Irpc gensairpc.pl --skip_error=-2,-3
  4. remove the new added parameters, add more doc Test done:
    make rpc

Signed-off-by: richardyu richardyu@contoso.com

Add decorator method in the perl template  for skipping test on specified error

details:
1. add decorator method in sai_adapter_utils.tt
2. use decorator when set parameters ``skip_error``
3. add parameters when building from template, like ``perl -Irpc gensairpc.pl  --skip_error=-2,-3``
4. remove the new added parameters, add more doc
Test done:
make  rpc

Signed-off-by: richardyu <richardyu@contoso.com>
@richardyu-ms richardyu-ms reopened this Oct 24, 2022
@richardyu-ms richardyu-ms changed the title [SAI-PTF] Add decorator for skipping test on specified error [Cherry-pick][SAI-PTF] Add decorator for skipping test on specified error Oct 24, 2022
@richardyu-ms richardyu-ms changed the title [Cherry-pick][SAI-PTF] Add decorator for skipping test on specified error [Cherry-pick][SAI-PTF] Add decorator for skipping test on specified error (#1609) Oct 24, 2022
@richardyu-ms richardyu-ms merged commit 9b667c6 into opencomputeproject:v1.7 Oct 24, 2022
@richardyu-ms richardyu-ms deleted the skip_unimpl_1.7 branch October 24, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant